Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carpentries lab and Toby Hodges acknowledgement in paper.md #134

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Carpentries lab and Toby Hodges acknowledgement in paper.md #134

merged 1 commit into from
Sep 13, 2023

Conversation

ewallace
Copy link
Collaborator

@ewallace ewallace commented Sep 7, 2023

Minor update to paper before JOSE submission - I'm not sure it really needs a review I'm asking for form.

@ewallace ewallace marked this pull request as ready for review September 7, 2023 11:31
@github-actions
Copy link

github-actions bot commented Sep 7, 2023 •
edited
Loading

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-lab/good-enough-practices/compare/md-outputs..md-outputs-PR-134

The following changes were observed in the rendered markdown documents:

 learner-profiles.md | 51 +++++++++++++++++++++++++++++++++++++++++++++++++--
 md5sum.txt          |  5 ++---
 paper.md            |  7 +++++--
 3 files changed, 56 insertions(+), 7 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-09-07 11:33:23 +0000

github-actions bot pushed a commit that referenced this pull request Sep 7, 2023
@actions-user
differences for PR #134
1bf2a19
ameynert
ameynert approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@ameynert ameynert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Very happy to see the updates from incubator > lab

@ewallace ewallace merged commit e0ef83b into main Sep 13, 2023
3 checks passed
@ewallace ewallace deleted the update-paper-jose branch September 13, 2023 08:38
github-actions bot pushed a commit that referenced this pull request Sep 13, 2023
@actions-user
markdown source builds
da6e6eb 
Auto-generated via {sandpaper}
Source  : e0ef83b
Branch  : main
Author  : Edward Wallace <[email protected]>
Time    : 2023-09-13 08:38:28 +0000
Message : Merge pull request #134 from carpentries-lab/update-paper-jose

Carpentries lab and Toby Hodges acknowledgement in paper.md
github-actions bot pushed a commit that referenced this pull request Sep 13, 2023
@actions-user
site deploy
91aa527 
Auto-generated via {sandpaper}
Source  : da6e6eb
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-09-13 08:39:57 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e0ef83b
Branch  : main
Author  : Edward Wallace <[email protected]>
Time    : 2023-09-13 08:38:28 +0000
Message : Merge pull request #134 from carpentries-lab/update-paper-jose

Carpentries lab and Toby Hodges acknowledgement in paper.md
github-actions bot pushed a commit that referenced this pull request Sep 19, 2023
@actions-user
site deploy
89a7fb9 
Auto-generated via {sandpaper}
Source  : da6e6eb
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-09-13 08:39:57 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e0ef83b
Branch  : main
Author  : Edward Wallace <[email protected]>
Time    : 2023-09-13 08:38:28 +0000
Message : Merge pull request #134 from carpentries-lab/update-paper-jose

Carpentries lab and Toby Hodges acknowledgement in paper.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameynert ameynert ameynert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewallace @ameynert